Albert Reed

Results 8 comments of Albert Reed

This PR doesn't process the audio - it just formats it to be compatible with google's API.

Update: I just stumbled onto this - the frame length here is the size of the block being sent to google and, as it turns out, 64k bytes is too...

I'd imagine it could happen if there's any number of things that hitch the thread and that it could happen on any number of devices. I'll fix it up and...

PR here: https://github.com/endoplasmic/google-assistant/pull/51

I just experimented to figure out what the correct value for MAX_FRAME_LENGTH should be. I'm not super-familiar with gRPCs so maybe someone knows how to look it up to make...

I remember reading somewhere that google specifically recommends not altering the raw audio. You raise an interesting point, though. My PR assumes that the error is concerned with the number...

If you're testing it I'd suggest throwing some different sampling rates at it. ...and adding proper automated testing is probably a good idea if you're going to be accepting changes...

Is there a timeline for when this might get merged in?