Alan Viverette
Alan Viverette
It looks like `ModuleMetadataJsonWriter` is using a `List`, which is a good start; however, we probably want to sort the list before writing to disk unless the inputs have a...
Slight correction, this is happening for the dependency list in the `pom` files as well, so it must be upstream of `GenerateModuleMetadata`. Updated title to reflect.
For module metadata, I believe this stems from `SoftwareComponentVariant` using an unordered `Set` to represent dependencies, constraints, excludes, etc. which are then transferred to an ordered `List` in `ModuleMetadataSpec.LocalVariant` before...
@stewartmiles Can you describe how the android.support dependencies are being pulled in by the JAR resolver? Jetifier can't rewrite the android.support libraries themselves in this case -- it's only intended...
I'll revert the original change from Gerrit, then re-apply it with correct line breaks. Otherwise the file history gets all messed up.
Given that you were the only author, this should be fine to take instead of a revert.
Presubmit is unhappy because there's no `Test:` stanza in the commit message. Please update your PR message to use `Bug: ` or `Fixes: ` for the bug numbers addressed and...
Still needs a `Test:` stanza. Given that we're not adding LeakCanary to the CI tests, I think `Test: manually ran with LeakCanary` is appropriate.
If @dlam and @tikurahul can't get this working, our GitHub workflow is busted. Let's keep pushing on this PR.
> @alanv @tikurahul @dlam @liutikas Hi, I see `@SuppressLint("BanUncheckedReflection")` is used in AndroidX code to suppress reflection warnings, can I add `@SuppressLint("BanUncheckedReflection")` to avoid this issue? Yes, this can be...