alandonovan

Results 69 comments of alandonovan

Thanks, but is this necessary? All the commands in the book such as `go get gopl.io/...` should work just fine without a go.mod file, and since the book predates and...

Hi Matt, thanks for contributing this change. I'm not sure yet where this feature belongs as it doesn't relate specifically to the Go implementation of Skylark, but various possible alternative...

Thanks Jon, lots of good material in here. Just a quick first pass. > Should Python's two's-complement operator (~) be included? It seems heavy-weight to include a whole new operator...

> ^, >. I presume you still want to include those as well? Yes.

For cmp and sorted, see https://github.com/google/skylark/pull/28

For set|iterable, see https://github.com/google/skylark/pull/29.

For the type of built-in functions, see https://github.com/google/skylark/pull/30.

Thanks! Once you've signed the CLA, we can commit this change.

Yes, Starlark does not support for/else, and this may be surprising to a Python programmer. On the other hand, a programmer familiar with every language but Python might stop and...

I was about to say that the desugaring is incorrect: the found=True statement should be outside the if statement. But then I checked and found that, no, you are correct,...