Alan Cai

Results 106 issues of Alan Cai

As part of #668, I created a personal repo, [test-partiql-version-migration](https://github.com/alancai98/test-partiql-version-migration), to test code examples between different `partiql-lang-kotlin` major versions. It would make more sense to have this under the `partiql`...

documentation

There are currently some hardcoded types added to the PIG domain. See `partiql.ion`: https://github.com/partiql/partiql-lang-kotlin/blob/fb7992468158d947557dc979f48a5f41ce83aa43/lang/resources/org/partiql/type-domains/partiql.ion#L392-L414 These types are temporary and should be removed as soon as possible so users don't take...

technical debt
S

`ExprNode` has been deprecated since [v0.6.0](https://github.com/partiql/partiql-lang-kotlin/releases/tag/v0.6.0-alpha). The parser, evaluator, and AST rewriting have migrated to use PIG-generated `PartiqlAst`. By the v1.0.0 release of `partiql-lang-kotlin`, we should remove and delete `ExprNode`...

technical debt

Thanks @alancai98, I can use `Order By` now. I also want to add alias support for `Order By` and `Group By`. Currently, following queries are not working because of missing...

enhancement
S

It will be important to document how the [PartiQL specification](https://partiql.org/assets/PartiQL-Specification.pdf) differs from the Kotlin reference implementation. This can include differences in supported features, syntax, and semantics.

documentation

`ReadFile.kt` has a couple TODO to take care of cleaning up the `FileInputStream` when the `ExprFunction` is called. Should involve closing the `FileInputStream`. First TODO in `ReadFile`: https://github.com/partiql/partiql-lang-kotlin/blob/fb7992468158d947557dc979f48a5f41ce83aa43/cli/src/org/partiql/cli/functions/ReadFile.kt#L92-L95 Another TODO...

bug
S
CLI

A common use case would be to round decimals and get the specified precision. This doesn't seem to be a SQL standard function, but it's a common enough use case...

enhancement
good first issue
M

A common use case would be to access values of previous/next rows in order to find the delta between rows. `LAG` and `LEAD` were introduced in the SQL 2011 standard...

enhancement
L

The current implementation of `expectVariableReferences` checks for the matched `expectation` for `VariableReference` and removes the same from `remainingExpectations`. This logic fails when the `VariableReference` is visited again and throws error....

technical debt
S
refactor

(related to https://github.com/partiql/partiql-lang-kotlin/issues/514) The `isNullable` and `isOptional` functions in `StaticTypeMapper.kt` can be removed once the tests are added. Source of the functions in `StaticTypeMapper`: https://github.com/partiql/partiql-lang-kotlin/blob/fb7992468158d947557dc979f48a5f41ce83aa43/lang/src/org/partiql/lang/mappers/StaticTypeMapper.kt#L23-L25

S