Alan Akbik
Alan Akbik
Hello @hauntsaninja thanks for updating this! Unfortunately it seems the update is breaking our unit tests. I think this may have something to do with some of the dependencies added...
@osanseviero looks good, though when I run this code: ```python from flair.models import SequenceTagger model: SequenceTagger = SequenceTagger.load('ner-fast') model.push_to_hub(repo_id='flair/test-push', private=True) ``` it fails with ~~~ OSError: You need to provide...
Could be related to #2919 - it would be good to have a consistent way of passing tokens.
Yes, a `token` parameter that defaults to `None` makes sense here!
Looks like mypy is throwing some odd errors again, somehow checking code in some cache directory: ``` FAILED cache/flair/datasets/senteval/data/convert.py::flake-8::FLAKE8 FAILED cache/flair/datasets/senteval/data/convert.py::ISORT FAILED cache/flair/datasets/senteval/data/mytokenize.py::mypy FAILED cache/flair/datasets/senteval/data/mytokenize.py::flake-8::FLAKE8 FAILED cache/flair/datasets/senteval/data/mytokenize.py::ISORT ``` @helpmefindaname do...
@HallerPatrick this should be fixed in master branch -> https://github.com/flairNLP/flair/pull/2665
hello @bratao yes we are looking into this now - sorry @helpmefindaname for taking so long, I first wanted to release Flair 0.11 (done yesterday) before making bigger changes.
@helpmefindaname I started reviewing, but it will take some time to think through all the changes. The logic of splitting out the tensor and non-tensor stuff in the forward pass...
Hello @helpmefindaname from a first look-through I like this structure a lot! Some suggestions: - `forward_pass` could be renamed into something that communicates that this is now only _optional_ intermediary...
@helpmefindaname thanks for fixing the rebase conflicts!