flair icon indicating copy to clipboard operation
flair copied to clipboard

Replace print with logging in model training

Open HallerPatrick opened this issue 3 years ago • 2 comments

Is your feature/enhancement request related to a problem? Please describe.

When using the ModelTrainer, everything is printed out through a logger, except for when the learning rate is reduced. This is just a normal print to stdout. See picture:

Screenshot 2022-03-23 at 20 22 46

Describe the solution you'd like For consistency, I would replace the print call with a logging call. For this the logger has to be passed from the ModelTrainer to the AnnealOnPlateu object or just use the global flair logger.

If this is enough for a PR, then I would assign myself to this

Greetings, Patrick

HallerPatrick avatar Mar 23 '22 19:03 HallerPatrick

@HallerPatrick this should be fixed in master branch -> https://github.com/flairNLP/flair/pull/2665

alanakbik avatar Mar 24 '22 03:03 alanakbik

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 19:07 stale[bot]