alan-baker comments

Results 154 comments of


                                            alan-baker

Missing intrinsic functions like rcp and rsqrt that are useful in other shading languages

`rsqrt` is `inverseSqrt` in WGSL. `rcp(x)` is just `1/x`. If we added `rcp` it would likely be with a different name (e.g. reciprocal).

wgsl: clarify what happens for IEEE 754 "invalid operation" cases, e.g. acos(2)

The `bgra8unorm-storage` feature should most likely only enable `write-only` access

I thought read-only would be polyfilled in SPIR-V with a texel fetch on a sampled texture and swizzle? I guess you'd have to play with the usage bits on the...

Image expectations problem

Here's the rest of the failures for that particular invocation (1D CL_FLOAT kernel_read_write). [test.log](https://github.com/KhronosGroup/OpenCL-CTS/files/10735435/test.log)

Image expectations problem

There were also failures with other image types/format. And failures in clFillImage tests too.

Image expectations problem

I don't have the exact cpu model, but it should be a skylake architecture. Fails in both -O1 and -O3 builds. Platform is Linux. No other compiler flags of note.

Add EarlyCSEPass before InstCombinePass (#1339)

It looks like this broke some test expectations.

-mfmt=c is not a valid option

Thanks for the report. Looks like we forgot the documentation updates when we unified some options.

wgsl: address space names are not keywords

This is covered in #3600

Move builtin must_use tests into per-builtin validation suites

Don't neglect `src/webgpu/shader/validation/expression/call/builtin/value_constructor.spec.ts`.