alan-baker comments

Results 153 comments of


                                            alan-baker

Support for physical addressing

Seems reasonable overall. A few points to consider: 1. You can only disable pointer transforms for global (and sometimes constant) address space. 2. More detail on the reflection design would...

Assertion in clang when referring to a structure type that doesn't exist

This is coming from the layout checks in the frontend. If I remove those clspv aborts later in the flow.

patch, add types to descriptormap

Can you expand on why you want types added to the descriptor map? None of the integrations of clspv I'm aware of have found that to be necessary. What kind...

Error handling in CLSPV

This should also address #13

acosh built-in function more accurate with -cl-native-math than without

Known issue, I ran into some devices that couldn't pass a relaxed version using the glsl extended instruction, but could with the libclc version. This has the unintended side effect...

acosh built-in function more accurate with -cl-native-math than without

When implementing the library I tested on swiftshader, an nvidia card, an amd card, a mali device and an adreno device. The mali and adreno failed full conformance with the...

acosh built-in function more accurate with -cl-native-math than without

I'l have to dig through my results again because you're right that OpenCL in relaxed mode considers acosh a derived implementation. Not sure when I'll get to that investigation though.

Fix Clang warning diagnostics

Please take a look at the build failures.

Build libclc as part of the build system

The failed builds are complaining about a CMake problem.

Build libclc as part of the build system

Thanks for looking into this. I admit that this PR is not the easiest thing for me to integrate into our internal builds. I do think it is the right...