Antoine Lamirault
Antoine Lamirault
@mtarld I can't "Re request review" but changes are done
(Rebased on current 6.2)
@nicolas-grekas I added layer and trigger deprecation (like urlMatcher) However, deprecation seems trigger even if methods are not called ``` 1x: The "Symfony\Component\Serializer\Mapping\AttributeMetadata::setSerializedName()" method will require a new "string[] $groups"...
Indeed, It's enough, thank you @chalasr
With this code, you make a recursive loop on `current` formatter. Instead using `getPlaceholderFormatterDefinition('current')` when `setPlaceholderFormatterDefinition('current)`, you maybe write something like this ```php $progress->setPlaceholderFormatterDefinition( 'current', fn (ProgressBar $bar) => 'Reading:...
Another approach is to not use same formatter name: ```php $progress->setPlaceholderFormatterDefinition( 'my_current', fn(ProgressBar $bar) => 'Reading: '.$bar->getPlaceholderFormatterDefinition('current')($bar) ); $progress->setFormat('%my_current%') ``` You can find default ProgressBar formats here: https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Console/Helper/ProgressBar.php#L551
Does anyone know how to implement it ? Is there native/efficient way to manage this ? (I'm very interested by this feature and can help to the PR)
Indeed it not works as explain in documentation. When there is no indexAttribute and no default index method we never try `getDefaultName` https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php#L79 (It was maybe introduced by https://github.com/symfony/symfony/pull/39203)
@javiereguiluz I understand, it's logic ! However, what do you think about adding a warning that checks are not all covered by Symfony on component's README ? And add link...
Thanks for your great reporting and possible solutions ! I created PR https://github.com/symfony/symfony/pull/47859 based on proposition one (Check and throw exception)