Andrew Lamb

Results 1965 comments of Andrew Lamb

Here is a potential strawman implementation that I think would be fairly straightforward to implement: 1. Use criterion and add a new `bench` benchmark (takes care of the warmup, measurements,...

> @alamb I won't be able to get to this until tomorrow, just letting you know No worries - thanks for doing it @suremarc -- I am traveling this week...

I think this PR is quite nice and it would be great if we could get the tests written and the code polished up. Marking as draft as I think...

@NGA-TRAN do you have time to review this PR as well?

No worries @suremarc -- I am very excited about this PR. I plan to review it sometime this week (hopefully later today)

Added API change label as I it adds a new field to `PartitionedFile`

> @alamb I added a config value, and I moved MinMaxStatistics to its own module as requested. I wasn't sure if I should delay addressing your feedback on tests to...

Filed https://github.com/apache/datafusion/issues/10336 to track enable this flag by default

> I'm happy to take this issue, but I just noticed that there is a draft PR already: #10067. @alamb would you like to finish that PR? I am on...

(Thank you @peter-toth 🙏 -- it is much fun working with you)