Andrew Lamb

Results 1535 comments of Andrew Lamb

> > One question -- do we need a flag though? My rationale is that converting from Utf8View --> Utf8 is not free. Thus users should have the option of...

BTW with this conversion in place, I think we could contemplate more interesting changes, like `substr` always outputing `Utf8View` even when the input was `Utf8`

> Thus, if we convert to non-view types on output, we do not risk regressing anything. Right -- I agree so this is why in my mind having the default...

> As I think, can we run the basic aggregation without any optimizations enabled and use its output as expected first, > and then we modify the options to enable...

> > > As I think, can we run the basic aggregation without any optimizations enabled and use its output as expected first, > > > and then we modify...

@Rachelint has made a great start here: https://github.com/apache/datafusion/pull/12667 What would you suggest the next steps here be @Rachelint ? Do you want to fill out the coverage? Would it be...

I will try and do so over the next few days. Thanks @Rachelint

Update here: 1. We have the basic framework in place 2. I have a PR up to restructure the tests to make it easier to add queries https://github.com/apache/datafusion/pull/12847 Here is...

> And I think maybe we can introduce a new trait named ArrayGenerator to unify the PrimitiveArrayGenerator and StringArrayGenerator? And it may make it easier to introduce new types. That...