Andrew Lamb

Results 1677 comments of Andrew Lamb

I ran the regexp benchmarks on this PR and verified that there are no changes for the existing types ``` ++ critcmp main fix/12150-regexprep-err-2 group main ----- ---- regexp_like_1000 1.00...

Thank you @Rachelint -- I hope to look at this more carefully tomorrow

Hi @Rachelint -- please let me know if/when this PR is ready for another look. I think your plan as I understand it is to get this idea working enough...

I plan to review this first thing tomorrow (when I am fresh and can focus)

I ran the benchmarks on my test machine and I see similar results Overall things get significantly better but a few get slower (e.g. `Q37`) but I suspect we can...

I plan to take another look at this tomorrow morning (again with fresh eyes -- lol)

> Hi @alamb main comments https://github.com/apache/datafusion/pull/11943#pullrequestreview-2254643945 for this pr have been fixed, minding have a quick look? It would be appreciated. Sorry for the delay -- I am back now...

Marking as draft as I don't think this is waiting on review and I am trying to keep the review backlog under control

> I wonder if we need to set up a plugin system for the CLI. I am happy to make a design proposal about it @alamb That would be awesome...