Aarni Koskela comments

Results 741 comments of


                                            Aarni Koskela

Non-critical corrections - June 2024 Edition

``` underultilization -> underutilization ultilization -> utilization ```

Fix of list index out of range error in PoFileParser.add_message when translations is empty

Thank you! The test was a bit buggy, so I went ahead and fixed that – and also that we don't do (a tiny bit of) extra work if we'd...

Rethink maintenance

@RuRo This project is being maintained in a support mode by yours truly. The latest patch version (for #782) was released 28 days ago, and the last minor version (2.9.0)...

Rethink maintenance

@RuRo Additionally, one reason more significant changes haven't been enacted is #569 – there are so many projects relying on unspecified versions of Babel I'd rather err on the side...

Loosen torchaudio version in requirements_minimal.txt

Yep, this works great for inference.

Fix #774: Allow object methods to be used as extraction-keywords

Thank you! Yeah, this makes sense, but we definitely don't want an extra dependency :) Maybe we can vendor (a subset of) `peekable` if that makes implementing this easier. Tests...

Changed get_week_number() to fix a problem with the locale en_AU

Yep, as Tomas said, a test would be very much appreciated - the week numbering logic seems to be pretty finicky all in all...

Babel fails to handle C locale properly

Could you show a little more of the traceback? In particular, is this program passing in an explicit locale, or is it trying to use Babel's default locale (which could...

option --init-missing of `pybabel update` should also create the corresponding directory

Makes sense! If you feel like writing a PR, that would be appreciated.

option --init-missing of `pybabel update` should also create the corresponding directory

Hmm – I'm actually unable to repro this 🤔 ``` ~/b/babel $ pybabel update --init-missing -i tests/messages/data/project/i18n/messages.pot -d $(mktemp -d) -l en_US creating catalog /var/folders/nz/6mg9yzdj1kq8lg2tsc5y9rlc0000gn/T/tmp.gNcQgcfVyp/en_US/LC_MESSAGES/messages.po based on tests/messages/data/project/i18n/messages.pot updating catalog...