Nicolas Hillegeer

Results 135 comments of Nicolas Hillegeer

Thanks for reporting, and thanks Damien for commenting. I tried doing a search-and-replace, but get errors: ``` integration_test.go:435: executing (go generate ./internal/cmd/generate-protos): exit status 1 executing: protoc --plugin=protoc-gen-go=/tmp/go-build3557462532/b001/exe/generate-protos --experimental_allow_proto3_optional --experimental_editions...

Thanks Damien, that may be it. I won't have time for this in the near future. Anyone in the community feel free to pick it up. I'll find time to...

(I don't know if this needs to be a proposal. It's not really a noteworthy feature, as it's an optional addition and only concerns very few users of a sub-tool,...

That's nice. I don't know much about catapult, but could it be made to display things in absolute time?

That's just reading AFAICT. I spent some time looking for writing and found `traceClockNow`: https://github.com/golang/go/blob/f2d118fd5f7e872804a5825ce29797f81a28b0fa/src/runtime/tracetime.go#L57-L62 nanotime is (on Linux) [`clock_gettime(CLOCK_MONOTONIC)`](https://man7.org/linux/man-pages/man3/clock_gettime.3.html). Which is (quoting man7) time since boot: ``` CLOCK_MONOTONIC A...

> Do you actually mean the CLOCK_REALTIME value (wall time)? We don't record that. I don't think that would be as useful for correlation with other trace events on the...

> There is a caveat that it will probably be difficult to precisely line up events using wall time, but I agree it would be useful even just for getting...

> We could just add this as a **new event type** that always lives in the same batch as EvFrequency... With respect to exposing this in the trace API, the...

Thanks a lot @felixge for working on this. It's indeed unfortunate that Catapult has no absolute timestamp viewer. I search around: - Perfetto seems to be able to do absolute...

From the peanut gallery: it may make sense to add a doc example on how to use the callback to make a request "synchronous". I assume it might involve `vim.wait()`...