Aviv Keshet
Aviv Keshet
It's a bit of an involved process for me to get CLA signing approval, so go ahead an fix it internally. Thanks!
> Looks like pre-commit needs to be run here Fixed manually, thanks!
> Thanks for this @akeshet, I think we definitely want to add such a parameter. > > However, similar to what @NickLucche said, could we make the type `Dict[str, str]`...
> If there's really no way around having `Any` as type here, I'd prefer `Optional[Dict[str, Any]]` but that is nit on my side. Done
> > In my particular use case, `Dict[str, str]` would not be sufficient, one of the extra args we need for our in house sampler is a (serializable) object. >...
@njhill I think all comments are addressed, could you take another look when convenient?
> Can you merge from main to try to fix the CI failures? Done, just pushed a merge.
``` Parameters that will not be supported in V1: ... logits_processors ``` Is this to say that support for logits_processors is going to be permanently dropped in V1, or is...