Alex Bertram

Results 77 comments of Alex Bertram

@psolaimani can you try building from source now? Can you verify that all tests pass?

For the time being, @psolaimani can you mark the tests that are failing on your machine as `@Ignore`d so that the build doesn't break randomly for those with non-English locale?

@bddbot add to whitelist

Looks good! I think you are probably missing an entry in the stat package's [NAMESPACE](https://github.com/bedatadriven/renjin/blob/0af7c5e99e1ccd04fda51fba2b6bfac6177c4491/packages/stats/NAMESPACE) file. Can you also add a simple test case for the `arima` function? See [test.stats.runmed.R](https://github.com/bedatadriven/renjin/blob/7f83a42f7fcf41313d6e8f6797ea7e2e3894036c/packages/stats/src/test/R/test.stats.runmed.R)...

Yes, this is a bit trickier. polyroot is an internal base function that basically has two parts: 1) `R_cpolyroot` and its subroutines constitute the actual C implementation of the algorithm...

Thanks for the bug report, can you propose a fix for the method? I'm afraid I'm not familiar with this algorithm at all.

@glascaleia Can you rebase this PR against the current head? Your patch is also quite large compared to the small changes that are being made - can you try to...