renjin icon indicating copy to clipboard operation
renjin copied to clipboard

Published 20 hours ago • verified publisher icon bedatadriven

Tests in TimeTest are local-sensitive

Open akbertram opened this issue 8 years ago • 7 comments

Expected: "2009-07-01 HST" Actual: "2009-07-01 -10:00"

akbertram avatar Mar 11 '16 14:03 akbertram

/cc @beattyk1 @hannesmuehleisen Does this test fail on your machine as well? On the master branch?

akbertram avatar Mar 11 '16 14:03 akbertram

@psolaimani What do we want to do about this? Is this something we fix or leave as platform-dependent?

akbertram avatar Apr 11 '16 07:04 akbertram

I haven't figured out how to resolve this yet, but if no packages are failing due to this issue we better focus on other issues first.

psolaimani avatar Apr 11 '16 16:04 psolaimani

An issue that breaks Renjin itself is a priority ! :-)

akbertram avatar Apr 11 '16 19:04 akbertram

A few findings:

According to the JavaDocs for the Joda time zone library we use, the time zone short name is locale-specific.

Indeed, if I open a fresh terminal and run

LC_TIME=nl_NL.utf8
mvn clean install

Then I can I get the error as well. This is probably what lead to the error on @psolaimani's machine.

akbertram avatar Apr 11 '16 20:04 akbertram

@psolaimani can you try building from source now? Can you verify that all tests pass?

akbertram avatar Apr 13 '16 09:04 akbertram

For the time being, @psolaimani can you mark the tests that are failing on your machine as @Ignored so that the build doesn't break randomly for those with non-English locale?

akbertram avatar Apr 19 '16 06:04 akbertram