Alan Kaptanoglu
Alan Kaptanoglu
I think this branch is ready to go -- now incorporates @landreman's suggestions and passing all checks I think (I'll add some coverage if need be). Only thing left on...
Few quick notes on some changes made in the course of fixing Matt's comments: 1. Coil class objects now come with a regularization property, e.g. regularization_rect(a,b). This seems like the...
> In the new force and torque objectives in `force.py`, I'm uneasy about how the coils are provided in two distinct groups, `allcoils` and `allcoils2`. Why is this necessary? This...
@landreman Okay right, I did this allcoils and allcoils2 because it allows you to only compute the forces of the coils you care about. In other words, I often found...
> > @landreman Okay right, I did this allcoils and allcoils2 because it allows you to only compute the forces of the coils you care about. In other words, I...
@landreman @mishapadidar any last comments? This looks ready. Thanks again for your help!
Okay, I took a look at the JaxCurves and noticed that CurvePlanarFourier python and C++ versions were not quite syntactically consistent (and JaxPlanarFourier was the correct one again...). So made...
Thank you _very much_ to everyone for their help here. This should be now passing all the checks again. I can submit a bunch of sub-PRs as suggested by Andrew...
> a few lines of code coverage are missing, can we get these covered? @andrewgiuliani coverage should be basically perfect now.
@mishapadidar I have implemented the RegularizedCoil class and moved some of the pareto scans to a file utils/coil_optimization_helper_functions.py. Unfortunately this also ballooned the PR a bit, since now those helper...