Alan Kaptanoglu
Alan Kaptanoglu
odeint just returns the trajectory anyways! So you can plot the finite values and see the blow up
Happy to get this over the finish line, but what is the advantage of this change? Seems like it addresses (https://github.com/hiddenSymmetries/simsopt/pull/467) although I don't think there is understanding still of...
Looks like when CVXPY calls the ECOS solver, ECOS is expecting a parameter "max_iters" (see https://www.cvxpy.org/tutorial/advanced/index.html), while usually (with the L1, let's say) it calls OSQP, which expects a parameter...
The implementation is based on a stability-promotion term with a 1/nu in front. So adjust the value of nu to be smaller to make things stable (the stability is not...
@landreman Will do. I assume this is because I run ./run_autopep before I commit things. Isn't this supposed to be the standard practice? @mishapadidar @mbkumar The latest version of the...
@landreman Just resolved those merge conflicts, thanks! We are down to 82 changed files but many of them are small edits!
Happy to approve this once you add a test of the logger warning, which is currently tanking the code coverage percentage here. Thanks!
> > Happy to approve this once you add a test of the logger warning, which is currently tanking the code coverage percentage here. Thanks! > > I didn't do...
@mbkumar heads up that I also see occasional failures of LpCurveForce and MeanSquaredForce, which rely on BiotSavart objects in the definition, but I do not ever see failures in very...
> Can you explain what's going on in the refactoring in this PR of `QfmResidual.dJ_by_dsurfacecoefficients()`? Was the previous implementation incorrect, or correct but slower? (Seems independent of the force and...