ak88
ak88
will be fixed by #6413
> > Nice catch, but maybe if `TerminalTotalDifficulty` is set we should just force enable MergePlugin? @MarekM25 WDYT? > > Yes, something like that. Funny - I've just written similar...
@LukaszRozmej @MarekM25 the merge plugin willl now throw if TerminalTotalDifficulty is set and merge == false
> Wny not implement this as a plugin instead. does not feel like it should be part of the main client Good idea - i will refactor it into a...
> For some reason can't access hive dashboard - @ak88 is it fixed with the PR mentioned? That PR fixes `TestBlobViolations` but not the other one.
There is misleading log statement here caused by: https://github.com/NethermindEth/nethermind/blob/c2529a99a33fc78e61bffa62f3c045c280f582cb/src/Nethermind/Nethermind.Consensus/Processing/ProcessingStats.cs#L106 This will calculate an incorrect amount of processed blocks, if a block gets processed out of order.
> why missing headers is not allowed? > > EDIT: Ah the response should have same number of items as request - it is protocol rules. But maybe we can...
superceded by #7459
> Good catch. Got another idea? The writelock is suppose to be use only during reset. Hm could introduce a new lock around HandleResponse and PrepareRequest. But I think the...
> `InsertHeaders` in `HandleResponse` is wrapped in a `lock (_handlerLock)` but `InsertHeaders` in `HandleDependentBatches` does not. Maybe thats the problem? I dont think that is sufficient to solve the problem,...