Anthony Towns

> Yeah, I also wonder what the use-case here is or was. Looks like it was introduced in v0.2.9 where it was used as a heuristic for determining if we're...

> Reduce `PeerManager`'s usage of `CNode` > Move the message handling loop to `PeerManager` Big fan of these aspects. I like the documentation aspect of NetManagerEvents. Would like to see...

> > For the last point, I think there are two main principles we should aim for: (a) minimising the movement and reparsing of data, and (b) minimising the locking...

Not sure if the flame graph is usable, but:  GetBoolArg takes up 0.31% of total time, as part of PushMessage that takes up 1.75% of total time, in b-msghand....

> Just to confirm, this flamegraph is from a node that has finished syncing to the tip? i.e. IBD is not included in this graph, right? Yes; it's taken over...

> it seems a bit absurd to check every `50ms` for a timeout of 20 minutes. Even the initial waiting time `m_peer_connect_timeout` from `ShouldRunInactivityChecks()` for a new peer doesn't really...

> Deprecate `getCoinbaseTx()` in favor of a new method that provides a struct with everything clients need to construct a coinbase. This is safer than providing a raw dummy coinbase...

> Unless we overhaul the sv2 [NewTemplate message](https://stratumprotocol.org/specification/07-Template-Distribution-Protocol/#72-newtemplate-server-client) it doesn't help Yes, I'm saying I think `NewTemplate` (and `CoinbaseOutputConstraints`) should be overhauled, to avoid sv2 software generating or modifying the...

ACK fa89f60e31d18b6c17d372f1cec26a4440e3d8b3 This is doing Debug in the first commit (which has no behaviour change), and Warning and Error in the second, but missing a couple of cases of Info...

> I like this, but is there a way to avoid reintroducing the mempool message transaction spying vulnerability? Construct the block skipping txn that have not yet been announced? Each...