Adrian Sutton
Adrian Sutton
https://github.com/ethereum-optimism/op-geth/pull/370 added a worker group with two implementations - one that doesn't create any go routines. And I'd forgotten again but actually we want to avoid concurrency when running in...
Awesome thanks. I just wanted to jump in early and flag the risk since I won't have time to look at this for a while and likely (hopefully) someone else...
One possible variant here is that the register deposit transaction is still required to be statically identifiable but the check for executing message validity does not happen synchronously - the...
Could the l2 head have changed between when a batch is added to the queue and when it actually gets processed as well? The use of a queue looks pretty...
Yeah the word `fixes` automatically closes. You can just mention the PR without that to link (e.g. https://github.com/ethereum-optimism/design-docs/pull/153)
I'd suggest it would be better to pull through the whole upstream release rather than cherry-picking. Otherwise we'll have a lot of conflicts to work through when we do pull...
Reopening as there's a todo referencing this.
Could you provide some information about why this is required? The `ctx` is managed internally (it uses `context.Background` as its parent) and right after its cancelled `l.done` is closed which...
I would suggest the portal retains the same ABI but can forward to the authorised caller as needed (ie build in backwards compatibility). Breaking the withdrawal API is a big...
Yeah agreed the key priority is maintaining compatibility with the withdrawal flow. Moving things like `respectedGameType`, `disputeGameBlacklist` and `respectedGameTypeUpatedAt` is likely to break some integrations like ENS but I feel...