Adrian Sutton

Results 168 comments of Adrian Sutton

Worth noting for the record that halting is an opt-in thing. It's actually very useful for a full node to prevent it following a non-upgraded chain if it misses an...

If you look at https://github.com/ethereum-optimism/op-geth/blob/425e757c51a1148cf6e3451157f1b666b2242b81/eth/backend.go#L616-L625 if `s.config.RollupHaltOnIncompatibleProtocolVersion` is not set, it does not halt. That config var is set in https://github.com/ethereum-optimism/op-geth/blob/352fbe634837af931b6d5128901b31cd2550bffe/cmd/utils/flags.go#L1848 to the value set in the `rollup.halt` flag which...

Note: fetching individual receipts from that same block does work.

Performed a resync from scratch and am still missing receipts for the same block via `eth_getBlockReceipts`.

For the record, I think it's more the commit than the particular block. I can't get any receipts from `eth_getBlockReceipts` after the resync.

Before diving into building sharable code, we should review how we approach configuration. It's usually better to have a well defined config file format so that each client can then...

Are the changes to the submodules deliberate? (Just checking because its so easy to accidentally change them)

Withdrawals root definitely makes sense for this. If we do want to use the extraData field though, we can take a leaf out of clique & IBFT's book and just...