Andrew Mason

Results 49 comments of Andrew Mason

So the "100%, State: postponing cut-over; ETA: due" is gh-ost working as intended. Because you specified the `--postpone-cut-over-flag-file`, gh-ost will wait to cut-over until either (1) you instruct it to...

I haven't forgotten about this! I should have time later this week.

> statistic preferences are hard to guess (block vs. non-block) :/ I totally feel you on this, but I still want that space in there! :) > The non-block style...

@rsajwani that `go list` doesn't make sense to me .. you're listing `go/cmd` and then seeing of that set if there are any packages in `go/cmd`, which is always going...

Feel free to cleanup the "DEPRECATED AND UNUSED" flags while you're there :)

I think your description is maybe pasted from some other PR? > Updates throttler related flag references specified in https://github.com/vitessio/vitess/issues/10893 this is for `vtctld` no?

i think you need to merge/rebase with main to get resolve the changes to `vtexplain.txt`, but otherwise LGTM whenever you're ready to move out of draft

so, new problem (maybe) i _think_ in order to get the vtctld_web_test to pass, i need to apply the following diff: ```diff diff --git a/web/vtctld2/src/app/shared/flags/flag.ts b/web/vtctld2/src/app/shared/flags/flag.ts index d8fc03d023..15107e001a 100644 ---...

yeah, i just went ahead and double-dashed everything. i also tried all morning to get `make web_bootstrap web_build` working, but i think it might be impossible on an m1 (i...

note the failing test will pass after we re-build the frontend bundle: ``` === RUN TestDashboardValidate vtctld_web_main_test.go:481: Error Trace: vtctld_web_main_test.go:481 vtctld_web_test.go:205 Error: elements differ extra elements in list A: ([]interface...