Arthur
Arthur
[backend/errors/httperror.go](https://github.com/openpredictionmarkets/socialpredict/blob/main/backend/errors/httperror.go) does not have test coverage. Add test coverage for the HandleHTTPError function should cover the cases: - err is nil - err is not nil this function is used...
Packages in go are mapped onto their directories (https://go.dev/blog/package-names#package-paths). Keeping this organization maintains logical grouping of code and expresses relationships with subpackages. Packages that need renaming: - possibly all packages...
This PR adds an interface type for the MarketCreation component of our setup config. This interface is implemented by both the EconomicConfig and MarketCreation types. There are a number of...
The router we use for the server handles http method mismatches: https://github.com/gorilla/mux/blob/db9d1d0073d27a0a2d9a8c1bc52aa0af4374d265/route.go#L58 We do not need to manually check the http methods. Remove these method checks from each of our...
Most of our handlers don't require the entire config to run- they're only dependent on a component struct of the config. - Create interfaces for the in-use components - Update...
Test the setup of the `EconomicConfig` struct marshaling by creating a yaml file and loading it. One benefit would be that it highlights the full workflow (i.e. load valid yaml...
This PR is not ready. It: - adds a `Bets` type to enable operating on multiple Bets at once - moves `ValidateBuy` to models/bets - updates function signature for `ValdiateBuy`...