Andrew Kryczka

Results 126 comments of Andrew Kryczka

I guess the file `//002462.sst` is also missing. ".sst" is the normal suffix but it looks like we try the ".ldb" suffix when a file is not found. Do you...

"This branch has conflicts that must be resolved"

It is a good question though - since the allocation and read already happened, does it make sense to return the value? I think it's not that straightforward. When using...

We can recreate this later after we review the fix (#10387) - seems it will take us a while to get there

Yes I talked to @cbi42 and believe he will try out the fix based on `manifest_write_cb` releasing files from compaction. Thanks very much for bringing this issue to our attention.

I did not realize at the time of writing that comment that the linked PR would not land. Now it looks like #11436 is more likely to provide the solution.

Nice finding. We should track whether the buffer is clean or dirty, and skip the write before sync when it's clean

It is difficult to guess. How did you build /tmp/librocksdbjni3872642940403144838.so?

Thanks. How was /install_data/ldb_toolchain built?