ajjindal

Results 11 comments of ajjindal

There's no specific integration with Google Cloud Run since it's a container platform and sentry instruments application code.

To clarify, this is not a bug but more like an ask to support handling of uncaught exceptions through third party like Sentry. I am looking for a pointer to...

Sorry for late response. I was checking on the recommendation with our tech lead. Yes, that + `onunhandledrejection` would be perfect.

oh that makes sense. we use the combination in our Node SDK but your suggestion makes sense. Will love to get `process.on`.

I must be missing something. Let me discuss internally and get back to the thread here.

So, the `process.on` will work. thanks for that. Our ask around 'onunhandledrejection` is for async handlers. However, if async handlers are not possible, we can skip on that ask. Thank...

I am good for now. Please close the issue. I can come back to this if we run into issues.

@grant We are trying to integrate now and looks like the problem with uncaught exceptions still exists. We are doing `process.on('uncaughtException', ...)` but `functions-framework-nodejs` sets such handler too: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/63cb628f580bc398924dd38e618498db36c76c82/src/invoker.ts#L255-L258. This...

@marshall-lee can you help me with a response here?

@marshall-lee is planning on creating a PR in the next couple days.