Ajay Bhargav

Results 25 comments of Ajay Bhargav

Thanks @eflukx. I can create pull request if @DaveGamble / @FSMaxB suggests.

@dussentue I can wait.. we can set a deadline for suggestions. code is ready on this branch. If needed, I can re-base and push again whenever you say. https://github.com/ajaybhargav/cJSON/tree/number_decimal_point

@bakeromso I have made a pull request #558 tested it with newlib and newlib-nano

Implementation tested with newlib and newlib-nano.

> Could this PR be merged? I just pushed PR again with rebase.

any update on this?

Its been 7 months since last commit. I wish there is an update...

but platform_memory_free is called again after destroy here https://github.com/jiejieTop/mqttclient/blob/956e0c8dcac02d4b107ccb49f1990c7718b6b585/mqttclient/mqttclient.c#L959-L960 So thread storage variable seems to be freed twice.

yes, either way, the two free has to be prevented. and yes ideally platform code needs to take care of allocation and free. Shall I make necessary change and push...

however, if you look at other implementations e.g. TencentOS, thread variable is not being freed. so other platforms are to modified too. https://github.com/jiejieTop/mqttclient/blob/956e0c8dcac02d4b107ccb49f1990c7718b6b585/platform/TencentOS-tiny/platform_thread.c#L58-L64