cJSON icon indicating copy to clipboard operation
cJSON copied to clipboard

Published 20 hours ago • verified publisher icon DaveGamble

Add API for adding number with fix decimal places

Open ajaybhargav opened this issue 4 years ago • 7 comments

In reference to discussion at issue #175

ajaybhargav avatar Feb 23 '21 11:02 ajaybhargav

Implementation tested with newlib and newlib-nano.

ajaybhargav avatar Feb 23 '21 11:02 ajaybhargav

Could this PR be merged?

bakeromso avatar Oct 04 '22 14:10 bakeromso

Could this PR be merged?

I just pushed PR again with rebase.

ajaybhargav avatar Oct 04 '22 20:10 ajaybhargav

I just pushed PR again with rebase.

Thank you for doing that! Hopefully, this PR can be merged now.

bakeromso avatar Oct 06 '22 08:10 bakeromso

Could this PR be merged?

wendal avatar Dec 06 '22 05:12 wendal

So , why not merge yet ? Everything seem ok

wendal avatar Dec 12 '22 04:12 wendal

Doesn't this only affect printing new numbers? I tried to utilize your changes in a program and it works great when printing once, but if you were to parse the json again and then print again, the decimal places you originally specified with cJSON_AddNumberWithPrecisionToObject won't be preserved.

So your changes here will only be affective when printing a cJSON object once?

sambyte61 avatar Jul 14 '23 21:07 sambyte61