Adam Williams

Results 64 comments of Adam Williams

This would be a great addition.

* `TInstanceConfig` represents the instance configuration and `TExecutionConfig` represents the result of `loadExecutionConfig`. Most of the changes are related to propagating this information throughout the code. * I thought it...

> Do you believe this will be a non-breaking version? I believe it should be non-breaking. > Can we help with the testing in handful of integrations? That will be...

"Would be very cool if you could run an SDK CLI command against a given integration and derive a Graphviz dot notation (or something equivalent) that could be rendered visually...

I didn't myself study the `multipleResolves` Node docs, but if this is indeed a bad thing to do, we should certainly not log as a `level: 30`, but `level: 50`...

It sounds like `multipleResolves` was an error in the context where this feature was developed, so we should keep it as `level: 50` and get the broken libraries patched ASAP,...

@fomentia that sounds reasonable to me. I guess it will use a string to compare to the error code or something like that? I'd be cautious of any `instanceof` checking...

Reading the [docs for Node `process.on('multipleResolves')`](https://github.com/nodejs/node/blob/master/doc/api/process.md#event-multipleresolves): > This is useful for tracking potential errors in an application while using the constructor. Otherwise such mistakes are silently swallowed due to being...

Chatting with @ndowmon IRL, the best approach: 1. Code the solution in the graph-qualys project so that we don't modify the SDK, nor do we only have this covered when...

Put some effort into understanding `multipleResolves`: https://jupiterone.atlassian.net/browse/INT-1813?focusedCommentId=11574