setup-python icon indicating copy to clipboard operation
setup-python copied to clipboard
verified publisher icon actions

Add support to .tool-version file format

Open elpic opened this issue 2 years ago • 11 comments

Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation

Ticket-ID: #571

Description:

Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation

Related issue:

https://github.com/actions/setup-python/issues/571

Check list:

  • [x] Mark if documentation changes are required.
  • [x] Mark if tests were added or updated to cover the changes.

elpic avatar Jan 17 '23 21:01 elpic

Hello @elpic! Thanks for your contribution! Some workflows failed, let's try to complete them. Could you please run the format and build commands?

e-korolevskii avatar Jan 18 '23 08:01 e-korolevskii

Would it be possible for you @dmitry-shibanov to run the failing tests?

elpic avatar Jan 20 '23 13:01 elpic

Hello @elpic, just a gentle ping.

dmitry-shibanov avatar Feb 21 '23 09:02 dmitry-shibanov

Hello @elpic, just a gentle ping.

e-korolevskii avatar Mar 14 '23 07:03 e-korolevskii

Sorry I will take a look in a moment

elpic avatar Mar 14 '23 11:03 elpic

Any chance this gets reviewed soon?

plukevdh avatar Apr 08 '23 05:04 plukevdh

Any chance this gets reviewed soon?

Looks like there are a few checks failing that need addressed. @elpic any chance you have time to turn this PR green? 😅

camflan avatar May 19 '23 15:05 camflan

Sorry for the delay. The code is formatted now

elpic avatar May 31 '23 12:05 elpic

@elpic this is a great improvement for this action 👏

tanguyantoine avatar Nov 30 '23 08:11 tanguyantoine

Can we get this merged?

tanguyantoine avatar Jan 04 '24 16:01 tanguyantoine

This would be a great addition.

aiwilliams avatar Aug 29 '24 14:08 aiwilliams