Alexander Ivanov
Alexander Ivanov
> I think you can do `with pytest.raises((ValueError, TypeError)):` > > > > any reason why you closed the PR? As long as we are fine with having `narwhals` and...
@MarcoGorelli Everything should be working now I think
gentle ping @MarcoGorelli
I'm currently on vacation will take a closer look into this again, but will be slower to respond, apologies for the delay thank you both @MarcoGorelli and @FBruzzesi for the...
fixed by xfail ~current ci fails with the new `zip_with`, due to a known issue in `modin`, [here](https://github.com/modin-project/modin/issues/7364)~ fixed ~ci fails because of [this](https://github.com/narwhals-dev/narwhals/pull/588/commits/fde2e9afc758ff4dc79c37324d164e88ef4974e8) if conditioning, which is essentially a...
@FBruzzesi I am slightly confused, it seems that a lot of the ci fails don't have anything to do with the changes in this pr? can you confirm this?
@FBruzzesi @MarcoGorelli I think this is ready for review now
ping @MarcoGorelli @FBruzzesi I'll resolve the merge conficts
With the merging of #2261 should we close this one @MarcoGorelli
No worries, unfortunately I haven't had the time to continue contributing so is good this has been resolved. Thank you @MarcoGorelli and team