narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard
verified publisher icon narwhals-dev

feat: add when chaining

Open aivanoved opened this issue 1 year ago • 4 comments

What type of PR is this? (check all applicable)

  • [ ] 💾 Refactor
  • [x] ✨ Feature
  • [ ] 🐛 Bug Fix
  • [ ] 🔧 Optimization
  • [ ] 📝 Documentation
  • [ ] ✅ Test
  • [ ] 🐳 Other

Related issues

  • Related issue #668
  • Closes #47
  • Extends #588

Checklist

  • [x] Code follows style guide (ruff)
  • [x] Tests added
  • [x] Address failing CI
  • [x] Make stable
  • [x] Documented the changes

If you have comments or can explain your changes, please do so below.

aivanoved avatar Jul 29 '24 14:07 aivanoved

@FBruzzesi I am slightly confused, it seems that a lot of the ci fails don't have anything to do with the changes in this pr? can you confirm this?

aivanoved avatar Sep 11 '24 22:09 aivanoved

@FBruzzesi I am slightly confused, it seems that a lot of the ci fails don't have anything to do with the changes in this pr? can you confirm this?

It's definitly unrelated. Also #942 passed all the tests. Polars had a new release, that's probably worth investigating

FBruzzesi avatar Sep 12 '24 06:09 FBruzzesi

yup, sorry about that - CI is green now 🥦

MarcoGorelli avatar Sep 14 '24 20:09 MarcoGorelli

@FBruzzesi @MarcoGorelli I think this is ready for review now

aivanoved avatar Sep 16 '24 10:09 aivanoved

ping @MarcoGorelli @FBruzzesi

I'll resolve the merge conficts

aivanoved avatar Oct 18 '24 13:10 aivanoved

With the merging of #2261 should we close this one @MarcoGorelli

aivanoved avatar Mar 27 '25 11:03 aivanoved

yeah maybe, sorry to close this - thanks for your PR, appreciate you having got the ball rolling on this one! 🙏

MarcoGorelli avatar Mar 27 '25 11:03 MarcoGorelli

No worries, unfortunately I haven't had the time to continue contributing so is good this has been resolved. Thank you @MarcoGorelli and team

aivanoved avatar Mar 27 '25 13:03 aivanoved