aiuto

Results 234 comments of aiuto

It's not my call, but I don't think we should be adding more functions to skylib unless they fill a clear need for many users. I won't be approving or...

Strong vote for `${var}`. - The leading `$` is widely used in scripting languages as a variable reference. It is universally familiar. - `$var` is insufficient because you you can't...

Is there some context about skylib needing to be split to multiple modules?

We have a long-standing philosophy in Bazel that decoupled file paths from filesystem attributes (the rwx bits). That is a reasonable thing in the context of remote build and immutable...

I haven't figured out if this is a good idea yet. It may be that the additional information is in the kind rather than the license. For example, the mention...

This feels like it should be in pkg_files. ``` pkg_files( name = 'foo', srcs = ['//some:tree_artifact'], attritbutes = '..' ) ``` and have the owner/group attributes apply everywhere. The mode...

So it sounds like we can fix this by just not having the root of the tree in the manifest. Then a pkg_mkdir can overlay on to that gap where...

Design note: - we don't want to have to unzip the entire package just to send it out to the remote executor to have the files read - thus, build_*.py...

We could start with pkg_expand only expanding things with PkgFilegroupInfo. That would essentially just re-return the PkgFilegroupInfo and remove the srcs from the DefaultInfo.

My plan: Phase 1: ``` pkg_expand( name = ..., srcs = [ tar or zip files ], preserve_owners = False, preserve_timestamps = False, exclude_paths = [path regexes], # maybe glob...