Aleksandr Borisov

Results 22 comments of Aleksandr Borisov

@toy yeah, I've got it. A lot of work these days, sorry :)

Let's discuss impact to speed for indexes removing. Here is example for sqlite3: ``` macbook-pro-2:temp aishek$ time sqlite3 test.sqlite3 < create_index_first.sql real 0m1.150s user 0m0.351s sys 0m0.179s macbook-pro-2:temp aishek$ time...

I am using `INDEX_FIELDS` because of [these approach](https://github.com/rails/rails/blob/6d72485b6977804a872dcfa5d7ade2cec74c768e/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L883). I'll little improved naming in last commits: now this array called `VALID_INDEX_OPTIONS`. I also removed additional `select`. I also added tests, rebased...

I'll fix these issues later. Thanks for detailed remark!

Ok, I fixed all: - added disabled by default environment variable with explanation in README - added mysql `lengths` support - added `with_disabled_indexes` specs - fixed codestyle issues There is...

Hi Justin, I am using initializer from engine: https://github.com/ai/evil-blocks/blob/master/lib/evil-blocks-rails.rb

I created initializer: ``` ruby # config/initializers/brakeman_slim.rb if defined?(Slim::Parser) shortcut = Slim::Parser.options[:shortcut] shortcut['@'] = { attr: 'data-role' } shortcut['@@'] = { attr: 'data-block' } Slim::Engine.options[:merge_attrs]['data-role'] = ' ' Slim::Engine.options[:merge_attrs]['data-block'] =...

Justin, thank you very much, I'd like to make pull request by myself. If I add code to brakeman, which will load `config/brakeman.rb` if present, where developer could put slim...

I'm stuck, Justin, please help :) Is there any possibility to told brakeman to use Slim shortcuts?