Joe Amenta

Results 212 comments of Joe Amenta

Base implementation probably needs to spin up a thread so that the visitor methods can block while our consumer processes the results. That said, I think every subclass can do...

Hmm, a more flexible API would be to have just one virtual method that returns something that can be configured like how the input classes work. I kinda want to...

Then again, I've come down elsewhere on the side of, "if you have some encoding other than UTF-8, then most helpers won't work for you". So only one parameter is...

Ugh. The ideal would be `IEnumerable` so that the consumer can choose whether or not to do a `.ToString()` themselves, at no meaningful extra cost on top of us allocating...

> So only one parameter is needed. Ugh. Of course that's not true: we also have `DecoderFallback`. Ugh.

`IEnumerable` might make more sense than `IEnumerable`? Someone might pull the next element from the outer sequence before fully consuming the previous element from the inner sequence (which is really...

Base implementation probably also needs to spin up a thread like the sync version, because I chose not to implement async visitors in favor of a cleaner API. Subclasses can...

I think we can skip the `Encoding` like #5 did... updating.

I think we can skip the `Encoding` like #5 did... updating.

> Technically, nothing's stopping us from exposing a `TextReader`-based API and decoding to UTF-8 on-the-fly so that it can work with the rest of the Cursively ecosystem. Well... if we're...