create-aio-app icon indicating copy to clipboard operation
create-aio-app copied to clipboard

add development.in

Open songmeo opened this issue 5 years ago • 5 comments

What do these changes do?

I add development.in to requirements folder.

Are there changes in behavior for the user?

no they aren't. Just to differentiate between direct dependencies and others.

Related issue number

issue #181

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [ ] Documentation reflects the changes
  • [ ] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

songmeo avatar Jul 10 '20 19:07 songmeo

Hi. Thx for ur contribution. I think that we don't need pip-tools for develop our template. But it'll so good for users who use create-aio-app. So instead move requirements-dev.txt what do u think about to do the same with this files https://github.com/aio-libs/create-aio-app/tree/master/create_aio_app/template/%7B%7Bcookiecutter.project_name%7D%7D/requirements?

What do u think about it? 😀

Arfey avatar Jul 17 '20 16:07 Arfey

What do you think?

songmeo avatar Jul 17 '20 21:07 songmeo

Sorry, but i don't understand what u wanna do. In issues which u attached to current pull request described about dependence which exist in this directory create-aio-app/create_aio_app/template/{{cookiecutter.project_name}}/requirements/ These dependence will use in project which create create-aio-app tool. Now, users use make update command for update these but main idea it drop check-requirements.py and use pip-tool instead.

Arfey avatar Jul 17 '20 22:07 Arfey

hello, sorry I didn't get it in the first place. What do you think of these changes now?

songmeo avatar Jul 18 '20 05:07 songmeo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '20 10:11 CLAassistant