create-aio-app icon indicating copy to clipboard operation
create-aio-app copied to clipboard

Updating version_check function

Open Conor0Callaghan opened this issue 5 years ago • 11 comments

What do these changes do?

These changes check that the create-aio-app is the latest version, PR requested by @Arfey https://github.com/aio-libs/create-aio-app/issues/104#issuecomment-599282303

Conor0Callaghan avatar Apr 15 '20 15:04 Conor0Callaghan

This pull request introduces 1 alert when merging 7ed8c7ffc0735296ceb0467cbbc225de8a264f10 into 88bf76809871bea733d5862f44a2a88237aedb49 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar Apr 15 '20 15:04 lgtm-com[bot]

Hi. Could u fix problem with error in build?

Arfey avatar May 15 '20 17:05 Arfey

I can't really see what the issue is @Arfey it seems to be failing on library click, but click is already in the requirements and is imported as part of the travis build.

Conor0Callaghan avatar May 19 '20 13:05 Conor0Callaghan

I see 2 error with bandit

>> Issue: [B310:blacklist] Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.
771   Severity: Medium   Confidence: High
772   Location: ./create_aio_app/utils/versiontools.py:51
773   More Info: https://bandit.readthedocs.io/en/latest/blacklists/blacklist_calls.html#b310-urllib-urlopen
77450	    try: 
77551	        with urllib.request.urlopen(PYPI_URL, timeout=0.1) as req:
77652	            res = json.loads(req.read())
777
778--------------------------------------------------
779>> Issue: [B110:try_except_pass] Try, Except, Pass detected.
780   Severity: Low   Confidence: High
781   Location: ./create_aio_app/utils/versiontools.py:61
782   More Info: https://bandit.readthedocs.io/en/latest/plugins/b110_try_except_pass.html
78360	            click.secho('pip install --upgrade create-aio-app',fg='yellow')
78461	    except:
78562	        pass

Error with click so similar with circle import in python. I think that problem with this import

import create_aio_app

as solution u can try move import into version_check function but I think there is a better solution.

if u'll not find solution text me and we'll try solve together

Arfey avatar May 21 '20 16:05 Arfey

This pull request introduces 1 alert when merging c4fb7b62258fa3d07726d26bd29961bb01ec302e into 34b1e70e28c8b43341391732f602fc4f52b56956 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar May 21 '20 21:05 lgtm-com[bot]

This pull request introduces 2 alerts when merging b0a758f37578cf16b6cd7ee13071d2e376d0be96 into 34b1e70e28c8b43341391732f602fc4f52b56956 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar May 21 '20 22:05 lgtm-com[bot]

This pull request introduces 1 alert when merging 3cbd444a01d14f3f3b9b86d38f65d5f18e4d7277 into 34b1e70e28c8b43341391732f602fc4f52b56956 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar May 21 '20 22:05 lgtm-com[bot]

I've refactored it to not use the import @Arfey but it still throws an error on the click import. Bandit is still throwing some warnings, but I expect them all.

Conor0Callaghan avatar May 23 '20 12:05 Conor0Callaghan

This pull request introduces 3 alerts when merging 5bad1864795ba1fae6d459ada8b8d2c26f97bb1c into 34b1e70e28c8b43341391732f602fc4f52b56956 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar May 23 '20 12:05 lgtm-com[bot]

This pull request introduces 1 alert when merging 1b8ec6698f718ac0612efbf6e947e78876462c56 into 34b1e70e28c8b43341391732f602fc4f52b56956 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

lgtm-com[bot] avatar May 23 '20 12:05 lgtm-com[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 16 '20 10:11 CLAassistant