Alex
Alex
I've added `array` typehint to `Result` class constructor in 4812b0f1fb9817b62e304e4c3200b0269137b151 because constructor itself was threating data as an array in the first place. It seems, that some of JIRA calls...
> A sniff that can enforce trailing commas (on multi-line arrays only) has been on my todo list for a long time. I've created such sniff myself for my standard....
Not sure that mentioned PHP features added in PHP versions after 5.3 would make any difference in the library currently. According to https://seld.be/notes/php-versions-stats-2015-edition the 10% of Web Servers are still...
@DerMika , we can't increase PHP version requirement for 1.0 release, so yes it will support PHP 5.3, but won't receive new features as 2.0.0 will do.
Supporting PHP 5.3 doesn't require extra resources and that's why it doesn't make sense not to support it.
We're not the ones to make decisions about that. As I said before: if we're not suffering from supporting EOL PHP versions, then no logical reason to stop supporting them...
Agreed. Also tests needs to be added for changed code fragments.
Please rebase due merge conflicts.
Today’s review completed.
@jpastoor , any updates?