Alex

Results 951 comments of Alex

> One of the reasons that I lost interest was the new Theme support that was added, and I didn't have time to convert this to a theme at the...

@nriley , as this (`brightness`) app developer would you please consider fixing this issue?

> I don't have a MacBook Pro M3 (nor do I have any plans to replace my perfectly functional M1 any time soon) so I have no way to test....

Yeah, I know. This is the problem with several other methods as well. PhpStorm always complains about it to me. Unfortunately we can't change argument order because that would be...

What we can do is to remove default value for `$method` argument. That sound like BC break, but in fact it is not, because when manually calling `Api::api` method you...

So, if you'd like you can send PR that would remove default value for optional method arguments, that come (in method declaration) before non-optional arguments. There are several such methods...

> And maybe in a future major bump we can fix it. I don't think, that changing argument order is a way to go, because in API calls the result...

@dereuromark , should I expect PR for review soon?

The issue will be fixed in https://github.com/minkphp/MinkSelenium2Driver/pull/382.