Abdechahid Ihya

Results 10 comments of Abdechahid Ihya

@EmilyBourne do you have an idea how to fix the codacy error?

> Using python lists directly causes errors in both C and Fortran if one of the values is `0` and when giving it a primitive list as a parameter: Example:...

> Please expand the tests to cover the special cases I can't think of special cases other than those in the tests.

I wonder if this function should deal with non-arrays only.

@EmilyBourne `numpy.sign(x, /, out=None, *, where=True, casting='same_kind', order='K', dtype=None, subok=True[, signature, extobj])` What the arguments `out`, `where`... should they be supported too?

> I'm not sure what is currently supported for our other functions. I tested other functions (e.g. `floor`, `abs`) with other arguments and pyccel complains, it says `Function call cannot...

An error is raised when I compile the following code for Fortran: ```python3 if __name__ == "__main__": print(round(42, ndigits=5)) ``` The error: ``` ERROR at shared library generation stage Traceback...

Following code is compiled for C ```python if __name__ == "__main__": print(round(42, ndigits=4.2)) ``` Output: ```shell $> pyccel test_round.py --language c /home/glitch/Documents/nandiniraja348/pyccel/codegen/compiling/compilers.py:431: UserWarning: /home/glitch/Documents/nandiniraja348/__pyccel__/prog_test_round.c: In function ‘main’: /home/glitch/Documents/nandiniraja348/__pyccel__/prog_test_round.c:7:15: warning: format...

> Please add a test that was failing before this PR fixed https://github.com/pyccel/pyccel/pull/1178/commits/8018659b37f10d57a67c065871fbca5325503e95

> Great job @aihya! Please add `sign` to the list of supported functions [here](https://github.com/pyccel/pyccel/blob/master/tutorial/numpy-functions.md#other-functions). Added here: https://github.com/pyccel/pyccel/pull/1169/commits/3e87899dd0cc7de5db95fe45a31c13c5f78aa131