Ignas Anikevicius

Results 504 comments of Ignas Anikevicius

OK to correctly model the whl selection to allow users to limit the number of selected wheels to minimum requires me to rewrite the `select_whls` function. I think the current...

I have something that builds the docs (i.e. can download sphinx) but I'll need more time to tidy this up fully.

I decided to not use this in rules_python yet, so this has dropped in my priority queue. If somebody is blocked by this, feel free to create a new PR...

Ran out of time today and this may contain some omissions, feel free to push here and reword things.

@rickeylev, I'll leave this open for you to have a chance to take a look.

Thanks for the PR. What is the usecase for overriding these templates?

There is an extra complication - if I remember correctly, pip is included as part of the hermetic toolchain and the behaviour here could be related to that. It is...

I am not fully sure about where it lives - it is up to us to decide - whatever is easier and whatever causes less friction is the best. I...

I think once the `python.*override` classes are implemented, the code will be easier to work with this. I am not sure yet what has to change and I don't have...

> All the override APIs need is_root checks, though -- letting intermediate modules override would cause quite a headache. Right now everything is under `mod.is_root` if statement, but I think...