Aidin

Results 13 comments of Aidin

You can do dynamic imports in TypeScript like so: ```ts export type PhosphorIcon = keyof Omit< typeof import("@phosphor-icons/react/dist/ssr"), "SSRBase" >; function DynamicIcon({ icon }: { icon: PhosphorIcon }) { const...

> Can you share sample code for usage? [@aidinio](https://github.com/aidinio) > > I guess this is how: > > An example usage would be: ```tsx ``` If you have code completion,...

> https://github.com/awesomeWM/awesome/actions/runs/10548999597/job/29229634679?pr=3943 Thanks for the hint. I fixed the problem.

> > I'm not sure why the test failed. > > Codecov fails because none of your lines are covered by tests and you end up below the target. That's...

@Aire-One Hi! Aren't there any other reviewers to approve my PR?

> but coverage is not enough: [#3991 (comment)](https://github.com/awesomeWM/awesome/pull/3991#issuecomment-2669332367) I've already added tests which resolve the coverage issue.

> yeah, codecov stuck on previous commit: https://app.codecov.io/gh/awesomeWM/awesome/pull/3991/commits Can I somehow restart the codecov check? It's stuck on "Waiting for status to be reported".

> now it's finally fixed, so you could rebase 👌😸 Thanks!

@dethdkn @bordermedia What did you downgrade?