awesome icon indicating copy to clipboard operation
awesome copied to clipboard

Add a rect shape with corners having different radii

Open aidinio opened this issue 10 months ago • 11 comments

Added a shape that can have a different radius on each corner.

aidinio avatar Feb 19 '25 10:02 aidinio

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.59%. Comparing base (691e364) to head (b37f0e1).

Files with missing lines Patch % Lines
lib/gears/shape.lua 4.76% 20 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3991      +/-   ##
==========================================
+ Coverage   48.37%   48.59%   +0.21%     
==========================================
  Files         194      195       +1     
  Lines       22400    22447      +47     
==========================================
+ Hits        10837    10909      +72     
+ Misses      11563    11538      -25     
Files with missing lines Coverage Δ
lib/gears/shape.lua 9.76% <4.76%> (-0.29%) :arrow_down:

... and 9 files with indirect coverage changes

codecov[bot] avatar Feb 19 '25 17:02 codecov[bot]

I'm not sure why the test failed.

aidinio avatar Feb 19 '25 17:02 aidinio

I'm not sure why the test failed.

Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.

sclu1034 avatar Feb 20 '25 19:02 sclu1034

I'm not sure why the test failed.

Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.

Thanks for the help. I also added tests.

aidinio avatar Feb 21 '25 11:02 aidinio

@Aire-One Hi! Aren't there any other reviewers to approve my PR?

aidinio avatar May 17 '25 12:05 aidinio

Hi @aidinio, sadly most other maintainers are AWOL for some time now... Let's try to ping @awesomeWM/write-access

Aire-One avatar May 17 '25 15:05 Aire-One

but coverage is not enough: #3991 (comment)

I've already added tests which resolve the coverage issue.

aidinio avatar May 18 '25 17:05 aidinio

yeah, codecov stuck on previous commit: https://app.codecov.io/gh/awesomeWM/awesome/pull/3991/commits

Can I somehow restart the codecov check? It's stuck on "Waiting for status to be reported".

aidinio avatar May 27 '25 09:05 aidinio

no, as CI currently broken: https://github.com/awesomeWM/awesome/issues/3994

actionless avatar May 27 '25 11:05 actionless

now it's finally fixed, so you could rebase 👌😸

actionless avatar Oct 05 '25 22:10 actionless

now it's finally fixed, so you could rebase 👌😸

Thanks!

aidinio avatar Oct 07 '25 10:10 aidinio