Add a rect shape with corners having different radii
Added a shape that can have a different radius on each corner.
Codecov Report
Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
Project coverage is 48.59%. Comparing base (
691e364) to head (b37f0e1).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/gears/shape.lua | 4.76% | 20 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3991 +/- ##
==========================================
+ Coverage 48.37% 48.59% +0.21%
==========================================
Files 194 195 +1
Lines 22400 22447 +47
==========================================
+ Hits 10837 10909 +72
+ Misses 11563 11538 -25
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/gears/shape.lua | 9.76% <4.76%> (-0.29%) |
:arrow_down: |
I'm not sure why the test failed.
I'm not sure why the test failed.
Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.
I'm not sure why the test failed.
Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.
Thanks for the help. I also added tests.
@Aire-One Hi! Aren't there any other reviewers to approve my PR?
Hi @aidinio, sadly most other maintainers are AWOL for some time now... Let's try to ping @awesomeWM/write-access
but coverage is not enough: #3991 (comment)
I've already added tests which resolve the coverage issue.
yeah, codecov stuck on previous commit: https://app.codecov.io/gh/awesomeWM/awesome/pull/3991/commits
Can I somehow restart the codecov check? It's stuck on "Waiting for status to be reported".
no, as CI currently broken: https://github.com/awesomeWM/awesome/issues/3994
now it's finally fixed, so you could rebase 👌😸
now it's finally fixed, so you could rebase 👌😸
Thanks!