Alex Williams

Results 36 comments of Alex Williams

The results look very strange. The bursting artifacts are edge effects. Can you provide a short code snippet which shows what you are doing?

> Fig.1C shows that for all trials the template time and clock time have little difference at the begining and ending. I'm not exactly sure that the figure shows that....

If you can find a way to fix it, I'm happy to review a PR to merge the change! On Sun, Jun 23, 2019, 3:58 AM Stefano wrote: > Hi....

Documentation for the offsets would be greatly appreciated!

> Actually, I think this convention for determining the allocation size is still not quite clean Yes, I agree. Cross-referencing from your examples in https://github.com/ahwillia/Einsum.jl/issues/6#issuecomment-245061487 I think I would prefer:...

What are the desired rules for pre-allocated arrays? ``` julia B = collect(1:10) # produce errors? A = zeros(5) @einsum A[i] = B[i+5] @einsum A[i] = B[i-5] # legal? A...

There has been a bit of discussion about this in the past, see https://github.com/ahwillia/Einsum.jl/issues/2 I'm not opposed to this at all and think it could be quite nice. I think...

> A conservative approach might be to start by only supporting pre-allocated array expressions. :+1: to this. I think this is a good place to start. > when the offset...

We should use `:offset` rather than `$offset` -- the second will try to interpolate which is not what we want.

I'm somewhat close to having this work. I still need to figure out conventions though. ``` julia @einsum A[j] := X[j + :offset] ``` What is the appropriate dimension check...