Alyssa Huang
Alyssa Huang
confirmed we get the same test error from insufficient poll time https://jenkins.confluent.io/job/Confluentinc%20Contributors/job/kafka-rest/job/PR-911/5/testReport/junit/io.confluent.kafkarest.integration.v3/ConsumerLagsResourceIntegrationTest/listConsumerLags_returnsConsumerLags/ ``` java.lang.AssertionError: Failed after 2987 ms elapsed and 3 exponential backoff retries with 200 ms initial retry interval....
Latest test run has 14 "new failing" which are all timeout related/unrelated - https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14206/17/tests
Is there a downside to having `deleteTopic` in `ZkTopicMigrationClient` not delete configs? Otherwise changing the logging level seems okay to me. [Edit] David explained offline that even if there are...
@mimaison tagging you again just in case you have time to take a look @mumrah I've added the logging change in the meantime - are we okay merging in the...
@mimaison the PR was originally meant to introduce additional test changes, I believe @mumrah renamed it after I added the migration fix. I'll move the tests out and apply your...
@mimaison @mumrah I moved unrelated test changes over to https://github.com/apache/kafka/pull/15373. The latest commit [1c1eb7d](https://github.com/apache/kafka/pull/15373/commits/1c1eb7d1a866c56188a97f6fa41940933e456c03) addresses the comments left here (mostly imports)
Thanks @mimaison, looks like this is because I split out the TopicsImageTest changes into a separate PR. The migration tests depend on the `DELTA1_RECORDS` defined there so I moved over...
@mimaison could you help merge this if this looks good to you? :)
@jiafu1115 thanks for the response and for testing it out manually! Good to see that the config isn't picked up by the other controllers. I wanted to clarify that my...
I think I agree that it might have less intended side effects to not delete the unknown configs. About the downgrade scenario, I would assume most cases where we're introducing...