Benjamin Wang

Results 627 comments of Benjamin Wang

> Do you plan breaking changes here? For bbolt golang public API, we will keep them compatible in all 1.x releases. For commands, we have two options, - 1. Migrate...

> Just making a point that before refactoring the codebase we should double check out test coverage for command line surface. It's a good suggestion. Currently we have test cases...

Just added test cases to cover all the commands which do not have cases before. https://github.com/etcd-io/bbolt/pull/474

The plan is to migrate all surgery commands to cobra style commands firstly. Please take a look at the first PR https://github.com/etcd-io/bbolt/pull/473 Afterwards, we can discuss whether to migrate other...

The plan is to migrate all surgery commands to cobra style commands in 1.4, and migrate all other old commands in 2.0. Does it make sense? > By default keep...

> can you link example PR or are there refs? would like to help migrating part of the command @ahrtr Thanks for the help. As I mentioned in https://github.com/etcd-io/bbolt/issues/472#issuecomment-1536207021, migrating...

Thanks for the improvement. - For the `DB` struct: Let's keep it unchanged. All unexported fields should be put at the bottom. The `stats Stats` is just a special case....

Please let me know if you have bandwidth to resolve my above comment https://github.com/etcd-io/bbolt/pull/673#issuecomment-1889409582

> Specifically, the node 2 has voted for node 3 @ term 2, and immediately went to the candidate state for term 3, even though it had no reason to...

> I think a better approach would be to verify if the rejection is due to outdated logs before delaying the next request. Yes, I was thinking the same. But...