Benjamin Wang

Results 627 comments of Benjamin Wang

Thanks for raising this. Unfortunately bbolt doesn't support plan9 so far. But it might just need minor effort to support it, - Add a new file `bolt_plan9.go` to implement flock,...

https://github.com/etcd-io/bbolt/pull/626#issuecomment-1837475990

Linked to https://github.com/etcd-io/bbolt/issues/665

> REF [containerd/containerd#9929 (comment)](https://github.com/containerd/containerd/issues/9929#issuecomment-1978318937) > The root page id (3393) is pointing to part of leaf page. > > =============================================== > Page ID: 3391 > Page Type: leaf > Total...

Thanks @ishan16696 . Please feel free to provide a PoC firstly.

It should be a feature request, please refer to https://github.com/etcd-io/bbolt/issues/665

The intention might be setting it as `50% * DefaultFillPercent` (50% * 0.5 = 25%)? cc @benbjohnson

I think we can add a field `FillPercent` (defaults to 0.5) into both `Options` and `DB`. It's the default value for `Bucket.FillPercent`, users can also set a different value after...

> Can we make rebalance threshold configurable that defaults to 25% (to keep it backwards compatible)? More flexibility doesn't mean better. I think we would better not to expose the...

The compacted/removed key (revisions in etcd) may be scattered everywhere in the db pages, but **the key point is etcd always adds new k/v at the end of the last...