Benjamin Wang

Results 627 comments of Benjamin Wang

If we want to support any new platform, then we should also verify them in the workflow.

Points: 1. Bucket isn't the only case to return `nil` value. Users can also put a `nil` value directly, then the returned value is also `nil` in such case. So...

> @ahrtr I think point 1 is not true. Even if I put `nil` as value, it is returned as empty slice when it is read. Note that there are...

> Why don't we fix this inconsistency and always return empty slice in both cases? On the contrary, I thought about always return `nil` in both cases.

Already added a known issue on the returned empty slice, please refer to https://github.com/etcd-io/bbolt?tab=readme-ov-file#known-issues. Also see https://github.com/etcd-io/bbolt/issues/726#issuecomment-2061694802 For the original question on ForEach and ForEachBucket, it isn't a big deal....

> [rates.db.zip](https://github.com/etcd-io/bbolt/files/11511652/rates.db.zip) Pages in [3655, 3715] were somehow reset. All zero values in these pages. FYI. https://github.com/etcd-io/bbolt/pull/520

> panic: invalid page type: 83597: 10 0x10 is the flag for freelist page. It means the freelist page was somehow in the tree

> the write I/O happen when requests are made, not when the DB is idle Do you mean you were trying to delete a bucket, and trying to update K/V...

> But then any request generate a maximum of I/O for no valid reason. Is the request successful? How long does the request take? How do you open the db?...

The page was somehow reset, in other words, all content in the page are zero values. FYI. https://github.com/etcd-io/bbolt/pull/520