Benjamin Wang

Results 627 comments of Benjamin Wang

This approach depends on the liveness probe's frequency / interval, the principle is `the instance is alive as long as there is at least one tick event since last liveness...

Thanks @highpon . ping @serathius @jmhbnz @wenjiaswe @fuweid for feedback.

> > cc @aojea for opinion as well > > I can see that there are multiple flags that declare addresses identifying the client, should you not use one of...

> I always prefer to have the use cases and document the scenarios with how the new knobs are supposed to be used before adding them. Yes, agreed on this....

> you can play with the localhost address 127.0.0.1 and the one in the node Thanks for the suggestion.

@highpon Please follow comments below to update https://github.com/etcd-io/etcd/pull/17085. Thanks - Let's add an option `--set-member-localaddr` (`bool`), which defaults to `false`. If users enable it, then let's use the host in...

> One question I had was whether we only wanted to set LocalAddr to an IP address, or should we try to resolve the DNS name to an address from...

I understand the feature request is to add separate `prevKV` flags for `PUT` and `DELETE` watch event separately. Note it changes the protocol/API between client and server, so we should...

There are 3 different feature requests, let's breakdown them into three different tickets. For 1, I vaguely recall that someone raised a PR to resolve it about 1.5 years ago,...